Hi Sławomir, thanks for the patch! It did not apply for me out of the box because it appears to have DOS line endings. I converted and applied it locally and all tests pass, but you might want to check if Git is set to automatically append LF.
Approved, for Ihor to look at. Cheers, Derek On Tue, May 5, 2026 at 2:05 AM Sławomir Grochowski < [email protected]> wrote: > Hi everyone, > > > > This patch adds tests coverage for the user-visible behavior of > `org-columns-quit'. > > The two new tests cover: > > - quit-leaves-buffer-editable: the buffer accepts edits after > > `org-columns-quit' — the `read-only' protection is gone. > > - quit-does-not-modify-buffer: entering and exiting column view > > does not leave the buffer marked as modified, even though the > teardown internally manipulates text properties. > > > Both tests assert user-visible behavior rather than implementation > details, so they should remain valid across future refactoring of > the column view teardown path. > > > Best, > -- > Slawomir Grochowski > > -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
