Thanks! The tests look good and apply to main (after dos2unix conversion). Approved, for Ihor to look at.
Cheers, Derek On Mon, May 4, 2026 at 12:38 PM Sławomir Grochowski < [email protected]> wrote: > Hi everyone, > > I have added characterization tests to go with the refactoring patch I > sent yesterday: '[PATCH] lisp/org-colview.el: Refactor conflicting minor > modes management'. > They act as a safety net to ensure that the observable behavior remains > unchanged. > > They exercise the public API only (org-columns, org-columns-quit) and > document the contract that column view temporarily turns off > flyspell-mode and org-num-mode on entry, then restores their original > state on exit. > > Because these tests do not reference the new internal helpers introduced > in yesterday's patch, they are valid both before and after the refactor. > > Please let me know what you think. The test suite passes locally. > Please apply this patch first. > > Best, > -- > Slawomir Grochowski > > -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
