Thanks for the patch! It applies cleanly to main (after dos2unix conversion) and the refactor makes sense to me. All tests pass.
Approved, for Ihor to look at. Cheers, Derek On Sun, May 3, 2026 at 4:58 AM Sławomir Grochowski < [email protected]> wrote: > Hi everyone, > > While looking at how org-colview.el handles minor modes that conflict > with column view (flyspell-mode and org-num-mode), I noticed that the > exact same initialization and cleanup code blocks are duplicated in > `org-columns' and `org-agenda-columns'. > > The attached patch performs a pure "Extract Function" refactoring. It > moves the logic for suspending and resuming these conflicting modes into > two new dedicated helper functions > (org-columns--suspend-conflicting-modes and > org-columns--resume-conflicting-modes). > > This change introduces no behavioral modifications but makes the code > cleaner and easier to maintain. > > I have run the test-org-colview test suite locally, and everything > passes successfully. > > Please let me know if you have any feedback or if any adjustments are > needed. > > Best, > -- > Slawomir Grochowski > > -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
