On 2026-05-06 10:41, Sławomir Grochowski wrote: > Is it OK to send patch like this?
AFAICT it’s allowed: https://orgmode.org/worg/org-contribute.html#org1716a16 (Sending patches with Git): > > For every patch you send, we suggest to use git format-patch or > > git send-email. > > --8<-- > > To finally send the patches, you can either add them as > > attachments to your email (easier) or use git send-email, if it's > > properly configured. On 2026-05-06 10:41, Sławomir Grochowski wrote: > But I think I haven't seen anyone doing that. One factor might be developers coming from Emacs, as they prefer attachments: https://cgit.git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE#n33 > > However, we prefer the 'git format-patch' method with attachment, > > as doing so delivers patches in the correct and > > easily-recognizable format more reliably, and makes the job of > > applying the patches easier and less error-prone. It also allows > > sending patches whose author is someone other than the email > > sender. Sometimes you do see submissions there over ‘git send-email’, and IMO it’s easier to quote diffs and structure reviews that way. Best, -- Jacob S. Gordon [email protected] Please don’t send me HTML emails or MS Office/Apple iWork documents. https://useplaintext.email/#etiquette https://www.fsf.org/campaigns/opendocument
