Bastien <[email protected]> writes: >> Note that this is a fairly common pattern. > > Over the last 172707 mails, we have 12802 occurrences of "[PATCH] " vs > 198 occurrences of "[PATCH]:", so rougly 1.5% of occurrences, and more > than 1/4 of them appearing within the last six months, mostly by Pedro > and you.
I did not create such subject line, AFAIK. > So I'm curious: was there a special reason to start using [PATCH]: ? I do not know the reason, just observe that non-negligible fraction of people use it. And if people use it, and in significant numbers, I do not see why such pattern cannot be supported. It is easy, easier than asking people to stick to other convention. > Here are the reasons I see to stick to "[PATCH] " : > > - git format-patch emits "[PATCH] ". > > - Most mailing list managers add subject labels and a space. > > - The column is used in patch subjects to indicate a topic, a convention > that BARK respects. For example in "[PATCH] org-agenda: add this", the > topic is "org-agenda". I would find "[PATCH]: org-agenda: add this" > confusing. It might be confusing, but from the perspective of bug tracker, it should be trivial to accept \[PATCH\]:? rather than just \[PATCH\]. >> Rather than trying to convince people not using this kind of subject >> line, we should rather allow such variant. Check the list archives - I >> see examples of [PATCH]: all the way back in 2007. Same in debbugs. > > In the last 50K emails from emacs-bugs@, I count 11 occurrences of > [PATCH]: vs 10K occurrences of "[PATCH]". Entirely up to you, of course, > but I read these numbers as saying that the most common convention is to > use "[PATCH] " - let me know if there is something I miss. I do not deny that the most common convention is [PATCH] followed by space. But I also see no reason to not accept a pattern that is somehow intuited by a number of people. My reasoning is mostly that it costs very little to support it, so why not. Another consideration is that the bug tracker should ideally "just work". Even for people who are not aware about the existence of the tracker and about the rules. So, text patterns that come naturally, and are also shared by a significant number of people may as well be supported. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
