Hi Ihor,

I am looking at `org-columns--compute-spec' in `org-colview.el' and
noticed this code:

  (if (bound-and-true-p org-inlinetask-max-level)
      org-inlinetask-max-level
    29)

However, I cannot find any definition of `org-inlinetask-max-level' in
Org.  In particular, `org-inlinetask.el' defines
`org-inlinetask-min-level', but does not mention
`org-inlinetask-max-level'.

Looking at history, `f4f0fc8bd' changed `org-inlinetask-min-level' to
`org-inlinetask-max-level', with the note that column summaries should
use the maximum, not minimum, possible inlinetask depth.

What makes the current state unclear to me is that `org-colview.el'
still declares:

  (defvar org-inlinetask-min-level)

but after `f4f0fc8bd' the file no longer uses that variable and instead
references the undeclared `org-inlinetask-max-level'.

Was `org-inlinetask-max-level' intended as an external/user-settable
escape hatch, or is this a stale reference to a variable that was never
added?  I am asking because I am refactoring this area and want to avoid
preserving misleading names or removing intentional behavior.

Would it make sense to keep the current `bound-and-true-p' fallback, or
should the code just use the hard-coded deepest level directly?

Best,
-- 
Slawomir Grochowski

Reply via email to