Jack Kamm <[email protected]> writes: > Ihor Radchenko <[email protected]> writes: > >> Jack, did you have a chance to look into this? > > Sorry for the delay, and thank you Ihor and Kyle for the implementation > suggestions. I'm attaching a patch here. It adds the directory > etc/org-babel, and inside it a Python module > ob_python_utils.py. ob-python.el then imports this file as a module, > following the same assumptions as oc-csl for the location. This also > reduces the number of modules polluting the global namespace in sessions > (eg ast, matplotlib). I did not cleanup the Python code too much, but > that could be a next step, eg based on Sam's suggestions, which should > be easier now that it's a separate Python file.
Thanks, and sorry for the late reply. The code looks good in general. Although python part can certainly be cleaned - docstrings; namespace for all imports might also use __private namespace; function complexity. > If it looks good, I might need some help getting it into upstream Emacs > repo in the right place. Looks good for me. Unless Kyle (who is taking care about upstream sync) has objections, I see no obstacles to merging. Further improvements can be discussed later. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
