Pedro Andres Aranda Gutierrez <[email protected]> writes: >> Also, I have no clue "please test this stuff!" is asking to do. >> > Then, you should have the same problem with the Beamer example I didn't > write ;|
Hmm. Yeah. Ok then. (I still do not like it, but let it be) >> > \texttt should not make a frame fragile, while \verb@@ should. So why >> use >> > frame* instead of frame in ltx-talk. >> > Side effect, we don't mark Beamer frames as fragile if they really aren't >> >> Ok, but can you make it a separate commit? > > Keep it here. If someone knowing ltx-talk sees a frame* that has nothing > fragile in it, that *will* raise questions. My point is that it changes beamer export as well, not just ltx-talk. If this change turns out to be a problem later, it will be very confusing that adding ltx-talk breaks beamer. My suggestion is simple: (1) change the beamer first; (2) apply ltx-talk support /after/ that change. >> > + (list >> > + (and (not (member "allowframebreaks" options)) >> > + (not (cl-some (lambda (s) (string-match-p >> "^label=" s)) >> > + options)) >> >> You did not address my comment here. >> We do not auto-generate label when it is provided in options, but what >> if name=... is given? >> > allowframebreaks is never mentioned in the ltx-talk manual. So this case > just doesn't apply. Consider a frame like ** Frame :PROPERTIES: :BEAMER_OPT: label=mylabel :END: This has nothing to do with allowframebreaks, I only meant >> > + (not (cl-some (lambda (s) (string-match-p >>> "^label=" s)) > >> +popular display formats. Additionally, the Beamer exporter also supports > > "Additionally, ... also" sounds strange. Again, this is minor. You did not address this comment. > +Added to check that the ltx-talk adaptation doesn't break anything in > Beamaer." *Beamer -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
