Hi,

The possible values passed to regexp-quote in this instance always assert

(equal val (regexp-quote val))

So why make the code unreadable?

Best, /PA

ox-latex and ox-beamer maintainer

-- 
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler

"Sagen's Paradeiser" (ORF: Als Radiohören gefährlich war) => write BE!
Year 2 of the New Koprocracy

IA: onomatopeya del rebuznar.

This was produced by a human (implied virtues and weaknesses acknowledged)
I'd hate this being fed to any form of A Stup (sorry AI)...
From 1de10a5d45ef430fa29d4fd6a6402b90bd311f5f Mon Sep 17 00:00:00 2001
From: "Pedro A. Aranda" <[email protected]>
Date: Thu, 9 Jul 2026 07:13:59 +0200
Subject: [PATCH] ox-beamer: remove unnecessary regexp-quote

* lisp/ox-beamer.el (org-beamer--format-frame): (regexp-quote label-str)
will return label-str, because the values label-str is assigned don't
need quoting.

A transcription from my scratch buffer, taking the significant lines in
the original code:
---
(defun test(latex-class)
  (let ((label-str (or (and (equal latex-class "beamer") "label")
                       "name")))
    (concat "^" label-str "=")))
test
(test "beamer")
"^label="
(test "ltx-talk")
"^name="
(test "ltx-typo")
"^name="
------
---
 lisp/ox-beamer.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ox-beamer.el b/lisp/ox-beamer.el
index 4548d77bf..44d4ce364 100644
--- a/lisp/ox-beamer.el
+++ b/lisp/ox-beamer.el
@@ -503,7 +503,7 @@ (defun org-beamer--format-frame (headline contents info)
 			 (not (cl-some
                              #'(lambda (s)
                                  (string-match-p
-                                  (concat "^" (regexp-quote label-str) "=")
+                                  (concat "^" label-str "=")
                                   s))
 			     options))
 			 (list
-- 
2.43.0

Reply via email to