"Pedro A. Aranda" <[email protected]> writes: > I think I submitted something in the lines of this a while ago. But it > also could be I haven't. So, new attempt with a new approach.
You previously introduced org-latex-default-example-environment. Applied, onto main, after fixing the commit message, removing unrelated commenting of (message ...) and adding one more test case with :options without [...]. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=90c612177 > Subject: [PATCH] Add default options to EXAMPLE > > * doc/org-manual.org: Document (org-latex-default-example-options) in > the EXAMPLE section. > * etc/ORG-NEWS: Announce new custom variable > (org-latex-default-example-options). This is a bit tangent to this particular patch, but I keep wondering if it is hard for you to follow the commit message guidelines. On one hand, it is not hard for me to fix the typos and format the commit messages, but that feels like something that should not be necessary for someone committing regularly. Maybe we can improve org-contribute page somehow to make it easier to follow? > * testing/lisp/test-ox-latex.el (test-ox-latex/pdf-metadata): Silence > debug message. This is not related to the patch at hand. I also see you using debug message in some patches but not in other. Do you prefer to keep messages in test? Or are those cases when you do keep (message ...) are just omissions? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
