The patch looks good! It applies cleanly to main, I don't see the compiler error Ihor was talking about, and the other concern he had around the docstring appears addressed. Can you go ahead and send the patch to the list so that Ihor can apply it?
Thanks,
Derek PLEASE double check everything. I *think* this has all of the changes along with the commit message that you had before.
I've attached an updated patch file that can be applied with "git am 0001-org-export-Add-new-after-includes-hook-for-org-expor.patch" to your local checkout of main. Ihor had a couple of remaining concerns, including the compiler warning and fixing the docstring. If you amend the commit you can then create a new patch file using the "git format-patch <commit hash>" and then attach it in your reply.
Cheers,
Derek
github has the concept of a pull request. I should have said “I don’t know how to do a pull request” or what is used as a substitute of a pull request.
As far as the commit message, typically that is more dictated by the group — not by the individual deveoper. Typically the group or the project wants the commit log to be “parsable” by the groups tools. Again, I don’t know what this group is using for such things, etc. Sorry for the confusion. Let me rephrase. It would be easier for me to help you review and update this patch if we use patch files instead of raw diffs. The main reason is that a patch can represent a complete commit, whereas a diff cannot. It also complicates things that you're not attaching the diff as a file, so I have to manually copy and paste things, but that's relatively minor. As an example, with your patch for ORG-NEWS, the diff doesn't tell me how you want the commit message updated. I guess I'm also trying to reconcile your statements of "I am using git" with "I don't know how to do...a commit message". Do you mean you're not sure of the format? I'll get the diff you sent applied but please let me know what wording you want for the ORG-NEWS change.
Cheers,
Derek
If you're using git, the simplest way for this would be to apply my patch against main using "git am <my patch file>" and then you can amend the commit with the ORG-NEWS change. Then to create the patch you do "git format-patch <hash or range>". If you're not familiar with git or don't have it readily available I can apply your patch on my side.
I don’t really understand this message. The diff (previous email) included all of the changes for this. The only thing it didn’t include was the change to the commit.
I am using git (which you can tell by examining the diff).
I’m not clear how to proceed.
Perry
-- +---------------------------------------------------------------+ | Derek Chen-Becker | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
-- +---------------------------------------------------------------+ | Derek Chen-Becker | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
-- +---------------------------------------------------------------+ | Derek Chen-Becker | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
|
0001-Provide-a-new-hook-that-runs-after-include-keywords-.patch