Lēctia Landau <[email protected]> writes: > It's a generic error, and it only prints the first line of it, simply > showing "class java.lang.RuntimeException" (note, I'm Clojure hosted > in Java, so this makes sense, it's just not very informative). > ... > However, on some further digging, I found the deeper issue in > ob-clojure--prepare-for-evaluation, which likewise did some > body-wrapping with parentheses which did not account for the body > maybe ending in a comment line. > > Attached is a new patch which fixes the underlying issues, which (in > my expertise of Clojure) means there's no more need to strip comments > in any situation, which my testing confirms. It's meant to be used > instead of the previous patch.
Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f9eeab715 I also added you to the contributor list. https://git.sr.ht/~bzg/worg/commit/56d3b03f > Sorry if I'm doing anything wrong, this is my first orgmode patch and > first mailing list, I'd certainly appreciate any feedback good or bad > on that front either. > > To clarify, it's still possible to keep the old behavior of filtering > out the comments, but (a) this is now a separate concern (b) there's > no good reason that I can tell to do so. The reason we were filtering the comments is to work around errors similar to what you reported. Your solution is cleaner. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
