Thanks for point out the docstring. I followed you advices to modified the patch. patch attached.
[stardiviner] <Hack this world!> GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Thu, Aug 27, 2026 at 10:14 PM Derek Chen-Becker <[email protected]> wrote: > Thanks for the patch! The patch applies cleanly and existing tests pass. > If you could add a unit test that would be helpful. There are a couple of > other things I'm not so sure about: > > - I think I would reword the description to focus on what it enables, > rather than discussing the internal `include-linked' variable. Maybe > something like "When non-nil, enable descriptive link previewing in > org-link-preview. When nil, descriptive previews can be enabled on a > per-call basis using 'C-u 1'.". You might also want to update the doc for > `org-link-preview' so people are aware of the variable. > - I'm not sure if "10.0" is the right value for the ":package-version" key > in the defcustom > - This seems like more than a TINYCHANGE. Are you on the contributor list? > > Ihor, what do you think? > > Cheers, > > Derek > > On Wed, Aug 26, 2026 at 10:46 PM stardiviner <[email protected]> wrote: > >> >> New custom variable ~org-link-preview-include-descriptive~ >> >> This option, nil by default, allow you to toggle the internal variable >> =include-linked= in function =org-link-preview=. So that user can >> globally enable descriptive links previewing without always pressing >> =[C-u 1]= to toggle the function parameter =include-linked=. >> >> >> -- >> >> [ stardiviner ] >> I try to make every word tell the meaning that I want to express without >> misunderstanding. >> >> Blog: https://stardiviner.github.io/ >> IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner >> GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 >> > > > -- > +---------------------------------------------------------------+ > | Derek Chen-Becker | > | GPG Key available at https://keybase.io/dchenbecker and | > | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | > | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | > +---------------------------------------------------------------+ > >
0001-ol-Add-new-custom-variable-org-link-preview-include-.patch
Description: Binary data
