Slawomir Grochowski <[email protected]> writes: > Ihor Radchenko <[email protected]> writes: > >> org-clock-sum was rewritten once in >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=bf9582255 >> However, because of the bug in org-element-cache-map, I had to revert >> that refactoring. > > Thanks for the info. I checked that commit, and it looks like it was > about rewriting `org-clock-sum' to use element API. > > My proposal is much simpler. It keeps the existing regex search but just > replaces the vector arrays with a stack. Since it doesn't touch > the AST cache at all, it's safe from those issues.
I am a bit hesitant because the element API version is what I really want in the long term. On the other hand, what you propose is an immediate improvement, so I can't (and should not) say no. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
