Morgan Smith <[email protected]> writes:

> Applied, as commit 6b508ea7c

Great, thanks.

> I cleaned up the commit message a bit.  Commit message standards are
> codified in the "GNU coding standards"
> <https://www.gnu.org/prep/standards/> which I should probably re-read at
> some point.  My memory of it is fuzzy and I sort of just format commit
> messages based on vibes at this point.
>
> In my opinion the two most important bits (again based on vibes and
> fuzzy memory) are:
>
> 1: A clear and concise first line that is no more then 68 characters
> (length is for some weird Emacs reason.  I forget why).
>
> 2: Everything touched is mentioned by its exact name so I can run "git
> log --grep=VAR-NAME" to figure out why something broke.

Thanks, I checked your changes and they are definitely much better than mine! I 
will try to learn from them :) I'll also have another read of the standards. 
Those two points seem to be quite important and I'll definitely keep them in 
mind for the future.

--
Paul

Reply via email to