Hi Nicolas,
Nicolas Goaziou <n.goaz...@gmail.com> writes:
>>>>>> Eric Schulte writes:
>
>> A potentially related issue,
>> The following org-mode snippet doesn't export correctly to latex,
>> presumably because of protection issues similar to those addressed in
>> your patch. Any ideas?
>
>> --8<---------------cut here---------------start------------->8---
>> ** comments not commented
>
>> # $some stuff
>> # some more stuff$ -- I should be a comment line
>> --8<---------------cut here---------------end--------------->8---
>
> Yes.
>
> Actually, the latex stuff is processed before taking care of comments
> (one of the last actions in every exporter). So the $...$ snippet is
> matched by org-latex and protected.
>
> This patch removes protection check from comment deletion : something
> in comment must not be exported anyway. I don't see any corner case
> right now.
>
Great. Thanks for the continuous flow of useful patches.
Not to look a gift patch in the mouth, but while this patch fixes the
above issue it looks like it introduces a new problem.
Before the patch the following
--8<---------------cut here---------------start------------->8---
** comments not commented
# $some stuff
# some more stuff$ -- I should be a comment line
1) a source block inside of an =enumerate=
#+source: plotxy
#+begin_src emacs-lisp :exports results
(message "I think so")
#+end_src
can cause problems
--8<---------------cut here---------------end--------------->8---
exports to
--8<---------------cut here---------------start------------->8---
\section{comments not commented}
\label{sec-1}
# some more stuff$ -- I should be a comment line
\begin{enumerate}
\item a source block inside of an \texttt{enumerate}
\begin{verbatim}
I think so
\end{verbatim}
can cause problems
\end{enumerate}
--8<---------------cut here---------------end--------------->8---
while after the patch it exports to
--8<---------------cut here---------------start------------->8---
\section{comments not commented}
\label{sec-1}
\begin{enumerate}
\item a source block inside of an \texttt{enumerate}
\#+source: plotxy
\#+results: plotxy
\begin{verbatim}
I think so
\end{verbatim}
can cause problems
\end{enumerate}
--8<---------------cut here---------------end--------------->8---
which is wrong in a different way.
>
>>> This patch looks great. Since it's >10 lines long, I must ask if you've
>>> signed the FSF papers for contributions to Emacs? If not is that
>>> something you're willing to do?
>
> I have sent the signed papers last Wednesday (I had to since my patch
> for org-babel-asymptote). I'm now waiting for their mail.
>
Oh, how forgetful of me, there's a todo in my agenda with your name on
it about checking up on the status of the FSF papers.
Thanks! -- Eric
>
> Regards,
>
> --
> Nicolas
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
