Hi Bastien,

thanks for the comments. I'll certainly keep that in mind for future
patches. Maybe that's something that could be added to the
corresponding worg page (http://orgmode.org/worg/org-contribute.html).

Best regards,

Valentin


On Tue, Aug 16, 2011 at 9:18 PM, Bastien <b...@altern.org> wrote:
> Hi Valentin,
>
> Valentin Wüstholz <wuesth...@gmail.com> writes:
>
>>> Meanwhile, could you please reformat a bit your patch (no more than 80
>>> columns, no parents on their own line), add a commit message followed
>>> by TINYCHANGE (unless you have signed FSF papers already) and use git
>>> format-patch for the output?
>>
>> Sure. I have attached the output.
>
> Thanks for making the effort of reformatting patches this way.  With
> so many patches coming in, it's really important that everyone tries to
> stick to immediately-applicable patches.
>
>> From c64f1b607d937c6484dfc18110125b1287175ac4 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Valentin=20W=FCstholz?= <wuesth...@gmail.com>
>> Date: Tue, 9 Aug 2011 21:28:56 +0200
>> Subject: [PATCH] Preserve indentation of explicitly indented lines in 
>> example blocks
>>
>> * lisp/org.el (org-indent-line-function): Made the way in which example 
>> blocks are
>>   indented more flexible.
>
> This line a bit long and should be something like:
>
>> * lisp/org.el (org-indent-line-function): Made the way in which
>>   example blocks are indented more flexible.
>
> Use M-q in change-log-mode on the ChangeLog to fill the region
> correctly.
>
>> Before: Lines in example blocks were indented like the surrounding begin and 
>> end
>> delimiters.
>> After: By default, lines in example blocks are indented like the surrounding 
>> begin and end
>> delimiters, unless the user explicitly indents them differently.
>
> Here again, I prefer <80 characters lines, but that's less important
> than the ChangeLog entry.
>
> Thanks,
>
> --
>  Bastien
>

Reply via email to