On 05/23/2012 05:53 PM, Nicolas Goaziou wrote:
Hello,
"Mark E. Shoulson"<m...@kli.org> writes:
There's a small bug in rendering the entities when org-pretty-entities
is on (I get the feeling that org-pretty-entities is not a very
commonly-used feature). The entities \sup1 \sup2 \sup3 and \there4 are
not rendered properly. The regex detecting entities apparently doesn't
catch numbers at the end, except for the special case of fractions. I've
added the others to the special-casing and attach a patch for it; I
hope I managed to include the changelog properly (is git format-patch -
-attach the way to go?).
This looks good. You should add a title to your patch, like "Fix
detection of entities ending with a number" or "org-entities: Add some
entities".
Also, please capitalize the word after the colons.
I was trying to copy the format seen in other patches on the list; I
guess I missed some details. I've set the subject of this thread as
I've seen done with other patches, and I attach only a single patch, as
requested by the website, and created the changelog with C-x 4 a and
everything. I hope I got it right.
Other patch follows under separate cover.
Could you modify slightly your changelogs before I apply the patches?
Thank you.
Regards,
>From 9b8e1b56c5c60720f985ea2b26952702c6c730a6 Mon Sep 17 00:00:00 2001
From: Mark Shoulson <m...@kli.org>
Date: Wed, 23 May 2012 20:17:40 -0400
Subject: [PATCH] Fix for displaying entities ending in a number
* lisp/org.el (org-fontify-entities): Fix bug: The entities \sup[123] and
\there4 were not "prettified" when org-pretty-entities was enabled.
TINYCHANGE
---
lisp/org.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index 0b00851..c44c7ab 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5966,7 +5966,7 @@ needs to be inserted at a specific position in the font-lock sequence.")
(when org-pretty-entities
(catch 'match
(while (re-search-forward
- "\\\\\\(frac[13][24]\\|[a-zA-Z]+\\)\\($\\|{}\\|[^[:alpha:]\n]\\)"
+ "\\\\\\(there4\\|sup[123]\\|frac[13][24]\\|[a-zA-Z]+\\)\\($\\|{}\\|[^[:alpha:]\n]\\)"
limit t)
(if (and (not (org-in-indented-comment-line))
(setq ee (org-entity-get (match-string 1)))
--
1.7.7.6
