> -----Original Message-----
> From: emacs-orgmode-bounces+mlt=gmx...@gnu.org [mailto:emacs-orgmode-
> bounces+mlt=gmx...@gnu.org] On Behalf Of Achim Gratz
> Sent: Monday, May 28, 2012 1:24 PM
> To: emacs-orgmode@gnu.org
> Subject: Re: [O] [babel, patch] ob-octave does not catch EOE from
matlabShell
> on MS Windows
>
> Eric Schulte writes:
> > Thanks for sending along the patch and the variable re-definition. If I
> > understand correctly then the patch should be applied for any system,
> > but the variable definition need only be applied on windows systems. Is
> > that correct?
>
> The variable re-definition seems to be be needed for matlab-shell, I
> don't know if that would be restricted to Windows.
>
> > Can anyone confirm that matlab/octave code blocks are still functional
> > on a GNU/Linux machine after the above patch and redefinition have been
> > applied? I do not use octave/matlab myself and can't verify this.
>
> The octave tests still pass on openSUSE with the patch applied along
> with all the other tests (except R, since I'm missing ESS).
I wonder how it still passes the test...
I think my patch unintentionally breaks octave. It probably should have been
just
org-babel-octave-eoe-output
instead of
(if matlabp
org-babel-octave-eoe-output
org-babel-octave-eoe-indicator)
or other way around.
I apologize for bringing it all over to the list as I'm not proficient in
elisp yet.
I feel like ob-octave needs an overhaul in general as it does not respect
many header arguments like :width, :height, and graphics format (always
png). Also it would be nice if it removed extra prompts left in results as
does ob-R.el .
I'll post improved patch once I feel it is ready.
Eric, so for now, just hold on with the application of what I've sent.
Mikhail
