Achim Gratz <strom...@nexgo.de> writes: > Bastien writes: >> However, I would suggest these changes to the current default.mk: > > These changes do not belong into default.mk — default.mk is the fallback > for when no changes to local.mk have been made. > >> - Have a target `make single' (useful for developers) >> >> - `make elint' would run the current `make _COMPILE_=slint3'. > > I don't like such proliferation of toplevel targets since they can't be > overridden by users,
I second the idea that a top level 'make elint' would be very useful for developers (see the attached patch). In my opinion this would be more useful than a number of existing top-level targets, e.g., config-*, update, update2, cleanall, cleandirs, cleancontrib, cleantesting, cleanutils, cleanelc and targets. So if we want to have fewer top level targets (which I think would also be a good idea), perhaps one or more of the above could be removed before an elint target is added. > things like this (an alias) are easy enough to set up in local.mk: But many more people will use such a target if it exists at the top level and is mentioned by "make help".
>From 39e1ce6e8f33561db94451248d1c17705bd8f4ee Mon Sep 17 00:00:00 2001 From: Eric Schulte <eric.schu...@gmx.com> Date: Mon, 13 Aug 2012 16:42:59 -0600 Subject: [PATCH] adding elint top-level Makefile target --- Makefile | 1 + targets.mk | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 71e2765..0b9535e 100644 --- a/Makefile +++ b/Makefile @@ -29,6 +29,7 @@ help helpall:: $(info make compile - build Org ELisp files) $(info make autoloads - create org-install.el to load Org in-place) $(info make check - build Org ELisp files and run test suite) + $(info make elint - perform a static check of ELisp source files) helpall:: $(info make test - ditto) $(info make compile-dirty - build only stale Org ELisp files) diff --git a/targets.mk b/targets.mk index 29b0aa5..7ddaff1 100644 --- a/targets.mk +++ b/targets.mk @@ -80,6 +80,9 @@ compile compile-dirty:: all clean-install:: $(foreach dir, $(SUBDIRS), $(MAKE) -C $(dir) $@;) +elint: + $(MAKE) -b _COMPILE_=slint3 + check test:: compile check test test-dirty:: -$(MKDIR) $(testdir) -- 1.7.11.4
-- Eric Schulte http://cs.unm.edu/~eschulte
