Hello, Yann Hodique <yann.hodi...@gmail.com> writes:
> thanks for the quick review. Of course I don't mind, but I'm just > curious to understand the purpose, as duplicating constants seems to > make room for future mistakes (even though in this case I guess we're > stuck with that regexp forever :)). As far as Org Element goes, there's no duplication as each regexp would be used but once. My point is that such constants do not make much sense. You are not guaranteed to find a real drawer when you use (re-search-forward org-drawer-regexp) even if the regexp matches: you also need to make sure that (eq (org-element-type (org-element-at-point)) 'drawer) is non-nil. Worse, I think that these constants are misleading as they sound self-sufficient. Therefore, I'd rather not support them in Elements. But I may be too cautious on this. What do you think? In the long run, I think that, structure-wise, org.el should handle any action directly related to headlines, but org-element.el should be the core library for everything else. Regards, -- Nicolas Goaziou