Hi Bill, sorry for the late (and probably disappointing) reply.
Bill Wishon <b...@wishon.org> writes: > This is my first major org-mode contribution, and I'm new to git, so > if there is something I haven't got quite right in terms of how to > contribute please advise. > > org-entry-get with inherit set didn't work for sub-heading additions > or overrides to properties found in parent headings as of Org-mode > version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can > not be found!). > > An example test org-mode file is attached (modified from the testing/ > examples directory and also updated in my git repository). Thanks for providing such a file with tests and examples. As far as I understand, problems are for cumulative properties, right? Eric, do you have time to check Bill's tests and see what's wrong with cumulative properties and inheritance? I'm not familiar enough with this part of the code to *enjoy* fixing this :) As for the patch themselves... 1) I did not receive confirmation from the FSF copyright clerk that your assignment is processed -- let me know if it is; 2) Please shrink commit messages and code lines to < 75 characters when possible. See org.el: we avoid long lines. This is not only for code readability, but also - and importantly here - for patch readability... If I overlooked a bug about something else than cumulative props, please let me know and let's have a separate fix for it. Thanks! -- Bastien
