Hi, Bastien <b...@altern.org> writes:
> No problem at all. I decided to go and accept patches from people > that did not confirm they got the FSF papers because merging 8.0 > into Emacs trunk is not likely to happen to soon... So. Good news, I got the confirmation that my "assignment/disclaimer process with the FSF is currently complete". I do not know however if I have to do something to prove that in order to submit patches to this mailing list. I then propose in attachment a set of four tests testing the problem mentioned in this thread: the behavior of org-open-at-point in front of bracket links and plain links.
From 5bd8eb52cb047b5290300fe850fca894babf05ff Mon Sep 17 00:00:00 2001 From: Samuel Loury <konubinix...@gmail.com> Date: Sat, 16 Mar 2013 20:12:42 +0100 Subject: [PATCH] Test the org-open-at-point function. * testing/examples/open-at-point.org: new file. * testing/lisp/test-org-open-at-point.el: new file. This tests only the function when inside or before bracket links and plain links. --- testing/examples/open-at-point.org | 8 +++++ testing/lisp/test-org-open-at-point.el | 61 ++++++++++++++++++++++++++++++++ 2 files changed, 69 insertions(+) create mode 100644 testing/examples/open-at-point.org create mode 100644 testing/lisp/test-org-open-at-point.el diff --git a/testing/examples/open-at-point.org b/testing/examples/open-at-point.org new file mode 100644 index 0000000..b3bb92d --- /dev/null +++ b/testing/examples/open-at-point.org @@ -0,0 +1,8 @@ + +* Header 1 + :PROPERTIES: + :ID: header1_with_great_id + :END: +* Header 2 + [[id:header1_with_great_id][Header 1]] + id:header1_with_great_id diff --git a/testing/lisp/test-org-open-at-point.el b/testing/lisp/test-org-open-at-point.el new file mode 100644 index 0000000..78724c8 --- /dev/null +++ b/testing/lisp/test-org-open-at-point.el @@ -0,0 +1,61 @@ +;;; test-org-open-at-point.el + +;; Copyright (c) Samuel Loury +;; Authors: Samuel Loury + +;; Released under the GNU General Public License version 3 +;; see: http://www.gnu.org/licenses/gpl-3.0.html + +;;;; Comments: + +;; Test for the org-open-at-point function + +;;; Code: + +(save-excursion + (set-buffer (get-buffer-create "test-org-open-at-point.el")) + (setq ly-here + (file-name-directory + (or load-file-name (buffer-file-name))))) + +(defun test-org-open-at-point/goto-fixture () + (find-file-other-window + (concat ly-here "../examples/open-at-point.org")) + (set-buffer "open-at-point.org")) + +(ert-deftest test-org-open-at-point/bracket-link-inside () + "Test `org-open-at-point' from inside a bracket link." + (test-org-open-at-point/goto-fixture) + ;; go inside the bracket link + (goto-char 113) + (org-open-at-point) + ;; should now be in front of the header + (should (equal (point) 2))) + +(ert-deftest test-org-open-at-point/plain-link-inside () + "Test `org-open-at-point' from inside a plain link." + (test-org-open-at-point/goto-fixture) + ;; go inside the plain link + (goto-char 126) + (org-open-at-point) + ;; should now be in front of the header + (should (equal (point) 2))) + +(ert-deftest test-org-open-at-point/bracket-link-before () + "Test `org-open-at-point' from before a bracket link but in the same line." + (test-org-open-at-point/goto-fixture) + ;; go before the bracket link + (goto-char 83) + (message "point %s" (point)) + (org-open-at-point) + ;; should now be in front of the header + (should (equal (point) 2))) + +(ert-deftest test-org-open-at-point/plain-link-before () + "Test `org-open-at-point' from before a plain link but in the same line." + (test-org-open-at-point/goto-fixture) + ;; go before the plain link + (goto-char 124) + (org-open-at-point) + ;; should now be in front of the header + (should (equal (point) 2))) -- 1.7.10.4
-- Konubinix GPG Key : 7439106A Fingerprint: 5993 BE7A DA65 E2D9 06CE 5C36 75D2 3CED 7439 106A
pgpJOvuA5BCP_.pgp
Description: PGP signature
