Hi Alan, Alan Schmitt wrote:
> A couple notes about the patch: > - Could you create it using "git format-patch"? This way we'll have > more metadata in the commit. I actually did that first and liked it more because then the patch was split into more logical blocks (nine patches in total). However, I did not add correct changelog entries to the commits. Should I resend the individual patches nevertheless? I could add/change the commit message manually in the email, I suppose. > - I think there is an issue with the handling of signatures. I tried > with an old letter that uses a LCO with a graphical signature in it, but > it gets overridden upon export. Here is the generated TeX. > > #+BEGIN_SRC latex > \LoadLetterOption{InriaRennesFR} > \setkomavar{signature}{\usekomavar{fromname}} > #+END_SRC > Have you tried clearing the signature? #+BEGIN_SRC emacs-lisp (setq org-koma-letter-signature nil) #+END_SRC Cheers, Viktor > > It seems to come from this part of the patch: > > #+BEGIN_SRC emacs-lisp > (signature (plist-get info :signature))) > (concat > ;; Letter Class Option File > (when lco > (let ((lco-files (split-string lco " ")) > (lco-def "")) > (dolist (lco-file lco-files lco-def) > (setq lco-def (format "%s\\LoadLetterOption{%s}\n" lco-def > lco-file))) > lco-def)) > ;; Define "From" data. > (when sender (format "\\setkomavar{fromname}{%s}\n" sender)) > (when from-address (format "\\setkomavar{fromaddress}{%s}\n" > from-address)) > (when phone-number (format "\\setkomavar{fromphone}{%s}\n" > phone-number)) > (when email (format "\\setkomavar{fromemail}{%s}\n" email)) > (when signature (format "\\setkomavar{signature}{%s}\n" signature)))) > #+END_SRC > > If signature is set for some reason (and it seems to be by default), > then it will override what is in the LCO. I have not found a way to > set the options such that the signature from the LCO gets picked up. > > Alan >