It's been a week and this test still fails. Would it make sense to automatically enforce passing all tests before git accepts a change?
On Wed, Nov 27, 2013 at 2:58 AM, Achim Gratz <strom...@nexgo.de> wrote: > > Hi Eric, > > this change seems to introduce additional line breaks in the following > test: > > --8<---------------cut here---------------start------------->8--- > Test test-ob/catches-all-references condition: > (ert-test-failed > ((should > (string= > (org-babel-execute-src-block) > "A literal example\non two lines for me.")) > :form > (string= "A literal example\non two lines\n for me." "A literal > example\non two lines for me.") > :value nil)) > FAILED 1/1 test-ob/catches-all-references > --8<---------------cut here---------------end--------------->8--- > > This seems to happen because the final \n from the babel result is not > stripped anymore, pointing to the change in ob-core. IIRC we > flip-flopped a few times already with including or not including this > final newline, so I don't know whether the code or the test should > change.
