Hi Bastien, Bastien <b...@gnu.org> writes: > Albert Krewinkel <tar...@moltkeplatz.de> writes: > >> * org.el (org-offer-links-in-entry): Use `org-any-link-re' to avoid >> code duplication. > > This is not really code duplication, as the output of `org-any-link-re' > is different from the output of the current sexp in the code.
I'm not exactly sure what you mean, are you referring to the variables' different representation in the source? I double checked that (string-equal re org-any-link-re) => t when `re' is set to the old value (as of commit 7c8559e). > That said, the change looks good anyway. Can you double-check there > cannot be any problem with the value of `org-any-link-re'? The variable is only ever changed when calling `org-make-link-regexps', so I'm quite positive that the change does not have any unintended side effects. The test suite passes, too. >> This is a TINYCHANGE. > > (TINYCHANGE should stand alone on the line.) Done. As an aside: I did sign the copyright assignment papers to be able to contrivute to Gnus, but that probably wouldn't help much, as Org is a different project. Is that correct? > Thanks! No, thank you all for all the work you put into this! It is truly amazing! Albert Krewinkel (1): org.el (org-offer-links-in-entry): Reuse global variable lisp/org.el | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) -- 2.0.0.rc0
