Bastien <b...@gnu.org> writes: > Hi Sébastien, > > Sebastien Vauban <sva-news-D0wtAvR13HarG/idocf...@public.gmane.org> > writes: > >> Even if the goal is desirable, I thought that we may not add defadvice >> in Emacs sources. > > True that, we need to clean things up. > > The route I will take is to apply Ian patch on master and then to > move all advising code into a separate org-advice.el library in the > contrib/ directory. Any suggestion for a better name?
I considered this problem when I made the patch, and originally started writing it to not use advise. The alternative I see is to create org-mode versions of these functions, and binding them with the org-mode-map to override the existing functions, like we do with other functions. I prefer advice in these cases because the advice is simple and it is easier for users customizing keybinds and extending emacs. However, compared to making it a module and thus not enabled by default, I would prefer to make org-mode versions of the functions. Having them on by default will be more helpful to more users overall. I would be happy to write the patch for this, if we agree.
