Hi Bastien,
Thank you very much for implementing this. Really appreciated. So do you think
it is a good idea to add my test (the patch) now for testing this?
For your convenience, I've attached again in this message the same patch I had
sent on April 10.
Thanks,
York
On Sun, Apr 20, 2014 at 3:56 PM, York Zhao <gtdplatf...@gmail.com> wrote:
> Hi Bastien,
>
> I apologize that I missed your reply, I discovered it until now when I was
> checking the replies in the "Sent" folder.
>
>> The question is this: are we fine handling raw links in properties,
>> or do we also need Org links (e.g. bracket links) there?
>
> To me, raw link is hardly useful because too often the web link is really
> long,
> in which case the bracket link acts like a way of abstraction.
>
> Thank you very much for considering this fix.
>
> On Thu, Apr 17, 2014 at 2:48 PM, Bastien <b...@gnu.org> wrote:
>> Hi York,
>>
>> York Zhao <gtdplatf...@gmail.com> writes:
>>
>>> * Peter
>>> :PROPERTIES:
>>> :ADDRESS: xxx xxx xxxx xxxx
>>> :HOME_PHONE: xxx xxx xxx
>>> :WORK_PHONE: xxx xxx xxx
>>> :URL: www.foo.bar
>>> :END:
>>
>> The question is this: are we fine handling raw links in properties,
>> or do we also need Org links (e.g. bracket links) there?
>>
>> Speaking for me, raw links is enough, and this is what I plan to
>> implement. But maybe other users have existing use-cases for Org
>> links there, I don't know.
>>
>> --
>> Bastien
From df0788134a16baa9762616637c0fe7f568e3e63e Mon Sep 17 00:00:00 2001
From: York Zhao <gtdplatf...@gmail.com>
Date: Thu, 10 Apr 2014 21:21:15 -0400
Subject: [PATCH] test-org-element: Add test for `org-open-at-point' with link
being heading property.
---
testing/lisp/test-org-element.el | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/testing/lisp/test-org-element.el b/testing/lisp/test-org-element.el
index 576e3d3..8cfceac 100644
--- a/testing/lisp/test-org-element.el
+++ b/testing/lisp/test-org-element.el
@@ -1461,6 +1461,15 @@ e^{i\\pi}+1=0
(search-forward "file:")
(org-element-property :type (org-element-context))))))
+(ert-deftest test-org-element/org-open-at-point ()
+ "Test `org-open-at-point' with link being a heading property."
+ (org-test-with-temp-text
+ "* Headline
+:PROPERTIES:
+:URL: <point>[[info:org#Top]]
+:END:"
+ (org-open-at-point)))
+
;;;; Macro
--
1.8.4
