Aaron Ecay <aarone...@gmail.com> writes: > Hi Rainer, > > 2014ko ekainak 21an, "Charles C. Berry"-ek idatzi zuen: >> >> On Fri, 20 Jun 2014, Rainer M Krug wrote: >> >>> Attached please find =the reworked patch. >>> >>> 1) uses local() and closes connection >>> 2) does not leave a variable cal;led file behind >>> >> >> Seems to work on a few test cases. >> >> I'd move the strings to defconsts. >> >> Putting a newline before each `%S' will outdent the first line of >> :var value when it is echoed in the session log so it will be easier to >> view. > > +1 to both of the above suggestions but otherwise the patch looks good > and I think it should be applied.
Thanks - a second patch has been send with the additional suggestions. Rainer -- Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, UCT), Dipl. Phys. (Germany) Centre of Excellence for Invasion Biology Stellenbosch University South Africa Tel : +33 - (0)9 53 10 27 44 Cell: +33 - (0)6 85 62 59 98 Fax : +33 - (0)9 58 10 27 44 Fax (D): +49 - (0)3 21 21 25 22 44 email: rai...@krugs.de Skype: RMkrug PGP: 0x0F52F982
pgpR9pZQV5Uyo.pgp
Description: PGP signature
