Brice Waegenire <brice....@gmail.com> wrote:
> I have took in consideration all of your points, is it better now?
> The current patch doesn't overwrite the present behavior of
> org-set-timer it only add the possibility to use hh:mm:ss format.
Thanks.
> From 8d6e379f3ed432511c613a0cf40804d2de1764b8 Mon Sep 17 00:00:00 2001
> From: Brice Waegeneire <brice....@gmail.com>
> Date: Fri, 24 Apr 2015 14:18:45 +0200
> Subject: [PATCH] org-timer.el: hh:mm:ss format for setting a timer
>
> * lisp/org-timer.el (org-timer-set-timer): Add support for hh:mm:ss format.
>
> * testing/lisp/test-org-timer.el (test-org-timer/set-timer): Add hh:mm:ss
> format in the test.
Minor: ChangeLog lines tend to be filled at around 72 characters.
[...]
> (read-from-minibuffer
> - "How many minutes left? "
> + "How much time left? (minutes or h:mm:ss) "
> (if (not (eq org-timer-default-timer 0))
> - (number-to-string org-timer-default-timer))))))
> + (eval org-timer-default-timer))))))
The defcustom for org-timer-default-timer now specifies a string and is
set to "0", so `(not (eq org-timer-default-timer 0))` will return t for
the default value of org-timer-default-timer. Something like
(and (not (string= org-timer-default-timer "0"))
org-timer-default-timer)
would be needed to keep the old behavior (i.e., only insert the value of
org-timer-default-timer as the initial prompt input if the user has
changed it).
> + (if (string-match "^[0-9]+$" minutes)
> + (setq minutes (concat minutes ":00")))
Minor: `when` could be used here.
Aside from that, this looks good to me. Thoughts from Nicolas or
others?
