> Menu selection functions on Mac (MenuSelect and PopUpMenuSelect) do > not return until the user selects an menu item or cancels the menu > selection. So I think menu-or-popup-active-p can always return Qnil > on Mac.
Thanks for the information. Hence DEFUN ("menu-or-popup-active-p", Fmenu_or_popup_active_p, Smenu_or_popup_active_p, 0, 0, 0, doc: /* Return t if a menu or popup dialog is active on selected frame. */) () { /* Always return Qnil since menu selection functions do not return until a selection has been made or cancelled. */ return Qnil; } will DTRT on Mac? But could you please try to make sure that the scenario described by Simon Marshall which started the current thread does not occur for the Mac port? I apologize for being paranoic here. > Actually, f->output_data.mac->menubar_active is not useful and > menubar_selection_callback is a misnomer. I guess they were simply > copied from the W32 counterparts (not by me). You mean `menubar_selection_callback' is exclusively called from `x_activate_menubar' via `do_menu_choice'? In that case, the references to menubar_active should be removed. _______________________________________________ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug