> Aside from that problem, this logic belongs inside convert_setup.
> This code's purpose is to just call the right convert_* function.
>
> You should probably not actually change block->p_number; none of the
> existing code works that way. Just handle it being zero inside
> convert_setup.
Ok new patch to fix these things
>
> For symmetry's sake, how do you feel about doing the same with
> convert_setup_tool? It is just as likely that someone wants to set a
> tool length as a G5x offset this way, I think. I am not sure if a
> random tool change machine can set a length on tool zero currently -
> if so, we've got a problem.
I'm not sure what you mean. Doesn't G10 L1 already use the current
coordinate system? The P parameter is tool number not coordinate
system.
> Maybe in that case, -1 would be the
> magic number you should use (for both)?
>
According to interp_checks tool 0 offsets cannot be changed with G10 L1
so P0 is ok to use though maybe in the future setting tool 0 is wanted?
then maybe P as -1 is safer.
One thing i notice is if you don't add P at all to g10 it is accepted that P = 0
So one could write G10 L2 x0 y0 z0
In a way I like that - if you don't specify a coordinate system the current one
is assumed.
> I like the idea - thanks for working on this.
>
> Chris
>
It's kinda fun to do a little work in EMC "proper" and see how the engine works!
Chris M
g10_l2_p0_patch2
Description: Binary data
------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
