Hello Sebastian, Thank you for your remarks. I corrected both and made the commits and branch naming more consequent.
Please push branch general-mechatronics-driver-v112. Full path: https://github.com/BenceKovacs/linuxcnc-mirror/tree/general- mechatronics-driver-v112 In case you have any more comment or you see mistake I should correct, please write. Further advices are always welcome. Thanks again for your work, Bence 2014-04-17 21:46 GMT+02:00 Sebastian Kuzminsky <[email protected]>: > On 4/17/14 12:39 , Bence Kovács wrote: > > Hello, > > > > Please push my modifications from: > > https://github.com/BenceKovacs/linuxcnc-mirror/ > > Branch: generalmechatronics-fix-2014-04-16 > > Compare link: > > > https://github.com/BenceKovacs/linuxcnc-mirror/compare/generalmechatronics-fix-2014-04-16 > > > > It has 3 commits: > > -Bug Fix: > > We found a critical problem with newer motherboards. Namely, PLX memory > > write was not enabled by default which made GM6_PCI card not working. It > > happened with Motherboards with AMI bios. We enabled it in driver. > > -Feature: > > Upgrade supported DAC resolution from 8 to 14 Bits. > > -Bug Fix: > > Eliminate new warning and increment driver version message. > > > > I don't know when 2.6 will be closed, but as this modification fix > critical > > bug, we would highly appreciate if it could be committed to 2.6. > > I'll push this branch to 2.6 for you. Bug fixes are always welcome in > stable branches like 2.6. > > Some feedback/requests: > > Could you rebase the branch from master onto 2.6? > > Also, it looks like your name and email got messed up on the first and > third commits in that branch. It's not the end of the world but please > try to fix it for future commits. The "Feature" commit in the middle > has correct name & email. > > > -- > Sebastian Kuzminsky > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/NeoTech > _______________________________________________ > Emc-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/emc-developers > ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
