On 05/22/2014 07:31 AM, Curtis Dutton wrote: > I don't believe it ever was merged. > > It is available here... > https://github.com/OKComputers/linuxcnc-mirror/tree/wj200_vfd
Looks like the code review issues i raised last time we talked about this driver have been addressed, that's great. It looks mergeable to me. It's unusual to have make targets to go from .comp to .c to executable, usually comp goes straight from .comp to the executable in one target. I understand that you're doing it this way because you need to give extra arguments to the C compiler to link your .c against the libmodbus libraries. It makes me think we should maybe augment the comp(1) command line to enable this kind of hackery... -- Sebastian Kuzminsky ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
