On Tue, Aug 18, 2015, at 02:47 PM, Jeff Epler wrote: > On Tue, Aug 18, 2015 at 12:50:55AM -0400, John Kasunich wrote: > > That's simply a matter of using the "net" namespace (and a consistent > > net name) instead of the "pin" namespace. > > Yes. Looking at the implementation, it looks at the pin namespace > first, then the net (sig) namespace, then the param namespace. > > I would feel much better if it looked at the net namespace only, or net > first and then param. > > If it looks at multiple namespaces, the docs should spell out why the > net namespace is the better choice of the available choices. > > I notice the code calls halpr_find_xxx_by_name without holding the rtapi > mutex which is incorrect use of these APIs. That isn't right, is it?
Nope. Line 350 of http://git.linuxcnc.org/gitweb?p=linuxcnc.git;a=blob;f=src/hal/hal_priv.h;h=18b664026885bc6f4a34434e851bfa2c2a6f40f5;hb=HEAD spells it out. Where is the actual implementation of this new feature? Is it actually part of the interpreter codebase? > > Jeff > > ------------------------------------------------------------------------------ > _______________________________________________ > Emc-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/emc-developers -- John Kasunich [email protected] ------------------------------------------------------------------------------ _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
