On 10/28/2015 01:51 PM, John Morris wrote: > > > On 10/27/2015 06:29 PM, Sebastian Kuzminsky wrote: >> On 10/27/15 1:38 PM, John Morris wrote: >>> I have an unusual bug fix for review. The commit [1] is based on >>> glo/master, but should apply to branches as old as 2011. The buildbot >>> is chunking away on it [2] right now. Thanks! >>> >>> John >>> >>> [1]: >>> http://git.linuxcnc.org/gitweb?p=linuxcnc.git;a=commit;h=2afd00a2074f014f0aad1f34e1e4d34214379f3d >> >> Hi John, nice to hear from you! I hope you're well. >> >> >> The test program in the commit message includes a nested comment, on the >> line it says to start running on. This causes the interpreter to stop & >> error out when I try it: >> >>> emc/task/emctask.cc 389: interp_error: Nested comment found >>> Nested comment found >>> Interpreter stack: - int Interp::close_and_downcase(char*) - int >>> Interp::read_text(const char*, FILE*, char*, char*, int*) - int >>> Interp::_read(const char*) >>> emcTaskPlanRead() returned 5 >>> emcTaskPlanClose() called at emc/task/emctaskmain.cc:768 >> >> >> If i change that comment to be valid, it runs fine as far as i can see. >> I did my testing on 2.6. I pushed a test using the new >> "motion-logger" testing framework, in a branch called 2.6-mountaindew. >> The test uses the correct syntax for the comment on line 5, and seems to >> me to have the correct behavior. >> >> > > Hi Seb, > > Thanks for looking at this, and especially thanks for the functional > test. That took some work. > > Apologies for the nested comment red herring and my improper testing > after rebasing onto glo/master. The test [1] now demonstrates the > problem properly, and the fix [2] should hopefully pass the Buildbot. > Once you're satisfied the bug actually exists, I'd appreciate another > look at the fix. > > [1]: http://git.linuxcnc.org/gitweb?p=linuxcnc.git;a=commit;h=08dce7b3
(One more fixup:) [2]: http://git.linuxcnc.org/gitweb?p=linuxcnc.git;a=commit;h=b714b534 > John ------------------------------------------------------------------------------ _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
