On Mon, Aug 15, 2016 at 03:27:11PM -0500, John Morris wrote:
>
>
> On 08/15/2016 02:43 PM, Jeff Epler wrote:
> > I have about an 80% solution to checking signed-off-by and showing it on
> > github pull requests as an automated check. You can see a PR that
> > satisfies our policy here in my personal github fork:
> >
> > https://github.com/jepler/linuxcnc/pull/3
> >
> > (for some reason you have to be signed in on github to see the result of
> > checks. then click the "show all checks" link just below the list of
> > commits)
> >
> > This requires a service hosted on public http(s); my chosen
> > implementation uses apache and python along with some random internet
> > and github components to glue everything together.
>
> Did I see you playing with automated builds on Travis CI recently?
> You're running custom web services to support the SOB check; could the
> functionality be moved to Travis?
Yes, we (I) recently did that. It's active for 2.7 and master branches,
and you should see pass/fails of the Travis CI build in your pull
requests if they are based off a new enough branch point.
At first glance, I didn't think a Travis CI build has enough information
to know this, but I see that some environment variables are provided
that may help:
TRAVIS_COMMIT_RANGE::
The range of commits that were included in the push or pull
request. (Note that this is empty for builds triggered by the
initial commit of a new branch.)
TRAVIS_PULL_REQUEST::
The pull request number if the current job is a pull request,
“false” if it’s not a pull request.
[https://docs.travis-ci.com/user/environment-variables/]
so yeah that is a promising idea! Do the SOB check as a pre-build step,
and no need to run a service for that.
Jeff
------------------------------------------------------------------------------
_______________________________________________
Emc-developers mailing list
Emc-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/emc-developers
