Andy: I wonder if things like that (bool options) should be INI setting?
I couldn't see a situation where you would want the option of using both (return speedup or not) in the same program. We don't seem to make policies, guides or plans so in the immediate picture, if it works lets merge. Seems that there are a lot of merge requests... maybe we need a merge fest :) My 2 cents Chris M ________________________________ From: andy pugh <[email protected]> Sent: November 30, 2017 3:18 PM To: EMC developers Subject: [Emc-developers] Asymmetric G33.1 Any thoughts on https://github.com/LinuxCNC/linuxcnc/pull/354 [https://avatars3.githubusercontent.com/u/707259?s=400&v=4]<https://github.com/LinuxCNC/linuxcnc/pull/354> adding optional I parameter to G33.1 which scales the spindle speed u… by rene-dev · Pull Request #354 · LinuxCNC/linuxcnc<https://github.com/LinuxCNC/linuxcnc/pull/354> github.com …p on the return move Signed-off-by: Rene Hopf [email protected] It seems that it should be safe as it leaves existing behaviour unchanged. -- atp "A motorcycle is a bicycle with a pandemonium attachment and is designed for the especial use of mechanical geniuses, daredevils and lunatics." — George Fitch, Atlanta Constitution Newspaper, 1916 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
