Hi guys, there is a problem in John Thornton's thc.comp in master branch. https://github.com/LinuxCNC/linuxcnc/blob/master/src/hal/components/thc.comp
This component includes a velocity tolerance setting (as a percent, say 10%) that is currently a parameter. The intent is that if the torch velocity falls below the commanded velocity by this percentage, THC functionality is disabled. This feature is commonly called a corner lock in the plasma industry as its designed to prevent the torch diving into the surface as the torch decelerates to negotiate a corner. The component also has an unused pin that by its name is meant to do the same thing as the parameter but the pin is never referenced in any code. In our view, the velocity tolerance should be a pin so it can be changed by a GUI control from one job to the next. It appears that an attempt was made to change from using a component to using a pin but the code was published without this being completed. This post on the forum provides more detail about this issue. https://forum.linuxcnc.org/plasma-laser/34517-enable-and-disable-thc-in-gcode?limitstart=0 I am attaching a revised component that reflects the change we believe should be made (eg, the parameter is removed and the pin is now referenced in the code instead). It would be appreciated if you guys could review this and push the revision to master branch. Rod Webster +61 435 765 611 Vehicle Modifications Network www.vehiclemods.net.au
thc.comp
Description: Binary data
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
