An option would be to have both ppmc.0.dout.03-invert and
ppmc.0.dout.03.invert with a note in the docs that ppmc.0.dout.03-invert
is deprecated and will be removed in the future.
Code wise it's ugly but you won't end up breaking anyone's configs.
Les
On 06/09/2018 16:48, Jon Elson wrote:
OUCH, I just found a typo in the hal_ppmc.c driver, most likely it has
been there since John Kasunich wrote it in 2005. Now, I have to
decide how to fix it.
So, for the PPMC DIO (the specific analog interface) and for the
Universal Stepper and PWM controller extra digital outputs, the invert
output parameter is like :
ppmc.0.dout.03.invert
But, due to the typo, the main digital outputs on the USC and UPC are
like :
ppmc.0.dout.03-invert
Note the HYPHEN!
Now, I could update the docs and leave the code as it is. But, that
makes things pretty inconsistent.
Since this has NEVER been noticed until now, I'm guessing VERY few
people have ever used this feature.
But, if I fix the code, then the driver will have different behavior
and syntax depending on the LinuxCNC version.
So, any suggestions? Call out the difference in syntax boldly in the
docs, or fix the code to be consistent?
Jon
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers
