On Thu, 18 Apr 2019 at 04:34, Chris Morley <[email protected]> wrote: > > While I was toying with a tool startup problem from the forum, I discovered > that iocontrol.cc never runs > the EMC_TOOL_INIT NML message even though taskclass.cc sends it.
EMC_TOOOL_INIT seems to load the tool table, but that is already done outside the loop. (Possibly because the tool init message was always being ignored...) Compare: https://github.com/LinuxCNC/linuxcnc/blob/master/src/emc/iotask/ioControl.cc#L699 https://github.com/LinuxCNC/linuxcnc/blob/master/src/emc/iotask/ioControl.cc#L771 > unfortunately just before that when checking halpins for changes the > echo_serial_number is advanced, I guess to sent the pin changes to status. If you remove the "+ 1" from https://github.com/LinuxCNC/linuxcnc/blob/master/src/emc/iotask/ioControl.cc#L726 then as far as I can see everything works just the same, except that now EMC_TOOL_INIT does now run. The HAL pins updated in iocontrol / read_hal_inputs() are emc-enable in (important) and lube-level (which I think we recently decided does nothing at all, and never has) E-stop appears to work if the "+ 1" is removed so I think that might be a bug. Note that read_tool_inputs() does _not_ add the +1, yet appears otherwise identical. I can't help feeling that we should remove the +1 and put all the too init stuff in EMC_TOOL_INIT. But on the other hand, it is all working as it is.... -- atp "A motorcycle is a bicycle with a pandemonium attachment and is designed for the especial use of mechanical geniuses, daredevils and lunatics." — George Fitch, Atlanta Constitution Newspaper, 1916 _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
