On Fri, 1 Nov 2019 at 04:04, Alec Ari via Emc-developers <emc-developers@lists.sourceforge.net> wrote:
> One of the things I noticed in LinuxCNC is that in src/rtapi/rtapi_math.h > there is this line: > extern double round(double); > But this apparently isn't used anywhere. If you comment it out, nothing > happens (it _will_ fail if a driver needs it) secondly, in kernel space, I > didn't add in the round function. This would be an undefined symbol in one of > the LinuxCNC modules. > round from rtapi_math.h looks safe to be removed. rtapi_math isn't just a list of what is used, though, it is a list of functions that _could_ be used. I think that round should stay in, there is no way to know if it is being used in a custom component somewhere. Looking on the forum there is a mention of it being used here: https://forum.linuxcnc.org/24-hal-components/26679-xhc-hb04-wireless-mpg-pendant-hal-module?start=40#36849 And also this interesting post: https://forum.linuxcnc.org/24-hal-components/30647-round-function-not-work#72110 -- atp "A motorcycle is a bicycle with a pandemonium attachment and is designed for the especial use of mechanical geniuses, daredevils and lunatics." — George Fitch, Atlanta Constitution Newspaper, 1916 _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers