On Mon, 8 Jun 2020 at 02:56, Reinhard <reinha...@schwarzrot-design.de> wrote:
> > What's the sense of runtests? > The tests are largely to check that fixed bugs have stayed fixed, many are based on specific problems previously encountered. It's a ringle command to run them and a 20 minute wait. It doesn't seem that much to ask. linuxcnc supports the most ridiculous functionality but has no tests for > the > very basics? > If you have identified gaps in the tests, then tests to fill those gaps would be welcome. > The diffs I sent where captured by "diff -Naur" which means, you can apply > the > code changes by running "patch" automatically. But that diffs are the > improvement only. > I suggested a pull request so as to document the change in the history and to correctly apply authorship. > To fix the bug, you should follow my description. Its just a one liner. Which bug are you talking about here? (The patch seems to be an enhancement rather than bug fix, so are you talking about the "G5x" item that you mentioned earlier?) -- atp "A motorcycle is a bicycle with a pandemonium attachment and is designed for the especial use of mechanical geniuses, daredevils and lunatics." — George Fitch, Atlanta Constitution Newspaper, 1912 _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
