Hello

I just built Buster and preempt and linuxcnc on an RPi3B ( not B+)

I could not loadrt hal_pi_gpio.

I got error Unrecognized revision.

I see there is an error in code to identify revision.

The file cpuinfo.c searches for the text "Raspberry" in the file /proc/cpuinfo.

It doesnt exist for my RPi3B

(the output of   cat /proc/cpuinfo  is attached )

So I hacked the cpuinfo.c

:::------code

   int  rpi_found = 0;

   if ((fp = fopen("/proc/cpuinfo", "r")) == NULL)
      return 0;

   while(!feof(fp)) {
      if (fgets(buffer, sizeof(buffer) , fp)){
      sscanf(buffer, "Model           : %s", model);
      if (strncmp(model, "Raspberry",9) == 0)
         rpi_found = 1;
      sscanf(buffer, "Revision  : %s", revision);
      }
   }
   fclose(fp);

   /* force value so module loads */
   /* the text Raspberry never appears in my 3B /proc/cpuinfo so rpi_found stays FALSE and module wont load */
   rpi_found=1;
  /* end force  */

:::------- end code

after the hack, and   make modules,  I can load the module and use the pins

:::

halrun

loadrt hal_pi_gpio dir=78855 exclude=32918520

show pin

:::

The validation code must be changed

but we may need many /proc/cpuinfo dumos for all the different Rpi models

thx

TomP

/*
Copyright (c) 2012 Ben Croston

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
of the Software, and to permit persons to whom the Software is furnished to do
so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
*/

#include <stdio.h>
#include <string.h>

char *get_cpuinfo_revision(char *revision)
{
   FILE *fp;
   char buffer[1024];
   char model[1024];
   int  rpi_found = 0;

   if ((fp = fopen("/proc/cpuinfo", "r")) == NULL)
      return 0;

   while(!feof(fp)) {
      if (fgets(buffer, sizeof(buffer) , fp)){
      sscanf(buffer, "Model           : %s", model);
      if (strncmp(model, "Raspberry",9) == 0)
         rpi_found = 1;
      sscanf(buffer, "Revision  : %s", revision);
      }
   }
   fclose(fp);

   /* force value so module loads */
   /* the text Raspberry never appears in my 3B /proc/cpuinfo   so rpi_found stays FALSE and module wont load */
   rpi_found=1;
  /* end force  */

   if (!rpi_found)
      revision = NULL;
   return revision;
}


int get_rpi_revision(void)
{
   char revision[1024] = {'\0'};

   if (get_cpuinfo_revision(revision) == NULL)
       return -1;

   if ((strcmp(revision, "0002") == 0) ||
       (strcmp(revision, "1000002") == 0 ) ||
       (strcmp(revision, "0003") == 0) ||
       (strcmp(revision, "1000003") == 0 ))
      return 1;
   else if ((strcmp(revision, "0004") == 0) ||
            (strcmp(revision, "1000004") == 0 ) ||
            (strcmp(revision, "0005") == 0) ||
            (strcmp(revision, "1000005") == 0 ) ||
            (strcmp(revision, "0006") == 0) ||
            (strcmp(revision, "1000006") == 0 ))
      return 2;
   else if ((strcmp(revision, "a01041") == 0) ||
            (strcmp(revision, "a21041") == 0) ||
            (strcmp(revision, "a22042") == 0))
      return 3;
   else if ((strcmp(revision, "a22082") == 0) ||
            (strcmp(revision, "a02082") == 0) ||
            (strcmp(revision, "a32082") == 0) ||
            (strcmp(revision, "a020d3") == 0))
      return 4;
   else if ((strcmp(revision, "a03111") == 0) ||
            (strcmp(revision, "b03111") == 0) ||
            (strcmp(revision, "b03112") == 0) ||
            (strcmp(revision, "c03111") == 0) ||
            (strcmp(revision, "c03112") == 0) ||
            (strcmp(revision, "d03114") == 0))
      return 5;
   else // assume rev 6
      return 6;
}
processor       : 0
model name      : ARMv7 Processor rev 4 (v7l)
BogoMIPS        : 38.40
Features        : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt 
vfpd32 lpae evtstrm crc32 
CPU implementer : 0x41
CPU architecture: 7
CPU variant     : 0x0
CPU part        : 0xd03
CPU revision    : 4

processor       : 1
model name      : ARMv7 Processor rev 4 (v7l)
BogoMIPS        : 38.40
Features        : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt 
vfpd32 lpae evtstrm crc32 
CPU implementer : 0x41
CPU architecture: 7
CPU variant     : 0x0
CPU part        : 0xd03
CPU revision    : 4

processor       : 2
model name      : ARMv7 Processor rev 4 (v7l)
BogoMIPS        : 38.40
Features        : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt 
vfpd32 lpae evtstrm crc32 
CPU implementer : 0x41
CPU architecture: 7
CPU variant     : 0x0
CPU part        : 0xd03
CPU revision    : 4

processor       : 3
model name      : ARMv7 Processor rev 4 (v7l)
BogoMIPS        : 38.40
Features        : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt 
vfpd32 lpae evtstrm crc32 
CPU implementer : 0x41
CPU architecture: 7
CPU variant     : 0x0
CPU part        : 0xd03
CPU revision    : 4

Hardware        : BCM2835
Revision        : a32082
Serial          : 00000000f118a297
_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers

Reply via email to