Looks good to me Andy. Thank you. ________________________________ From: andy pugh <bodge...@gmail.com> Sent: December 31, 2023 11:58 AM To: EMC developers <emc-developers@lists.sourceforge.net> Subject: Re: [Emc-developers] Merge 2.9 to master - Partially completed
Chris M: Can you look at linuxcnc/lib/python/qtvcp/qt_pstat.py? Based on commit dates I think you probably wanted both sets of changes in? (functions mportDefaultHandler from 2.9 and isUsingDefaultHandler + getQSSPaths from master? Håvard F. Aasen: Can you take a look at emcrsh.cc lines 573-584 & 1246-1253,? Your commit 18f0295 changed the handling of some string checks, but master was already significantly changed by https://github.com/LinuxCNC/linuxcnc/commit/8b91f27d5f9c2523e4e4350efa38e5264aa51280 using rtapi_strlcpy, which I think is maybe better? I have kept the master version. -- atp "A motorcycle is a bicycle with a pandemonium attachment and is designed for the especial use of mechanical geniuses, daredevils and lunatics." — George Fitch, Atlanta Constitution Newspaper, 1912 _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
