On Fri, Aug 10, 2012, at 07:17 PM, Matt Shaver wrote:
> On Thu, 9 Aug 2012 04:35:56 +0000
> Chris Morley <[email protected]> wrote:
> 
> > motion-motion-enabled is an output pin from motion to tell you when
> > the machine is on. AFAIK there is no all powerful 'integrator feed
> > hold' though it would be useful..
> 
> An OUTPUT you say...
> 
> >From the man page:
>        motion.motion-enabled IN BIT
> 
> $ halcmd show all | grep enabled
>      9  bit   IN          FALSE  motion.motion-enabled
> 
> >From motion.c:
>       hal_pin_bit_new("motion.motion-enabled", HAL_IN,
>       &(emcmot_hal_data->motion_enabled), mot_comp_id);
> 
> And yet, you're right, it does seem to be intended as an output.
> Mis-defined as an input maybe in motion.c? Should we fix this, or is
> there something we're not seeing yet about this?

I probably wrote that line of code.  It is quite possible
that I wrote it wrong.  Pin export code is something that
almost always got copy-pasted.

I don't have the source handy.  I suggest grepping for
"emcmot_hal_data->motion_enabled", or maybe just "->motion_enabled"
and see whether the motion controller is reading it or writing
it.  I suspect there are only one or two lines of code that touch
that structure member, so it shouldn't be too hard to figure out.

I think the usual pin naming convention would be "motion-enable"
for an input - the outside world tells the motion controller
"enable yourself".  For an output is is "motion-enabled",
the controller telling the world "I am enabled".  So I think
Chris is right, it was probably intended as an output.  But
check the code to be sure.



-- 
  John Kasunich
  [email protected]


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Emc-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-users

Reply via email to