Jorgen Schaefer <[EMAIL PROTECTED]> writes:
> Yoni Rabkin Katzenell <[EMAIL PROTECTED]> writes:
>
>> If it helps anyone to locate where to make the changes:
>>
>> $:~/elisp/emms$ darcs whatsnew
>> {
>> hunk ./emms-info-mp3info.el 79
>> - (string-match "\\.[Mm][Pp]3\\'" (emms-track-name track)))
>> + (string-match "\.\(?:\(?:M[Pp]\|mp\)3\)" (emms-track-name
>> track)))
>> hunk ./emms-info-ogginfo.el 50
>> - (string-match "\\.[Oo][Gg][Gg]\\'" (emms-track-name track)))
>> + (string-match "\.\(?:O\(?:GG\|gg\)\|ogg\)" (emms-track-name
>> track)))
>> }
>
> These regular expressions won't match many file names, which
> explains why you notice the speedup.
Makes sense!
> You need to escape the
> parentheses twice, once for the string, and once for the regular
> expression engine.
>
> I.e.
> "\\.\\(?:\\(?:M[Pp]\\|mp\\)3\\)"
> "\\.\\(?:O\\(?:GG\\|gg\\)\\|ogg\\)"
>
> Sorry for not noticing this when you asked on the channel.
>
Well... with the above and another change I've now managed to completely
bork my local emms, so I didn't even notice them not matching!
Good thing I did not try and make it into a patch. Or darcs emms would
have been borkened everywhere.
Thanks for trying it out.
--
"Cut your own wood and it will warm you twice"
_______________________________________________
Emms-help mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/emms-help
