The patch looks good to me, FWIW. On Sun, May 20, 2012 at 7:40 AM, Daniel Dehennin < daniel.dehen...@baby-gnu.org> wrote:
> Daniel Dehennin <daniel.dehen...@baby-gnu.org> writes: > > > Daniel Dehennin <daniel.dehen...@baby-gnu.org> writes: > > > >> Hello, > > Hello, > > >> Back in 2005[1], I tried to change the case of tags. > > > > [...] > > > > I finally manage to get it working, you can pull a signed tag[1] from my > repository: > > > > The following changes since commit > 298e022d7fba7a991fcc9cf25306a7b8eb8a612e: > > > > * lisp/emms-browser.el (emms-browser-track-duration): New function to > allow custom browser track-formats to display track duration. (2011-04-25 > 18:51:28 +0200) > > > > are available in the git repository at: > > > > > > git://git.baby-gnu.net/emmscons-cell-usable-in-emms-tag-editor-replace-in-tag > > > > for you to fetch changes up to 53f82af975bb76a8bef46ee3d3fa849da26d4fdf: > > > > Make cons cell usable when replacing a tag and fix an end-of-line > match loop. (2012-02-04 18:38:04 +0100) > > > > ---------------------------------------------------------------- > > As reported on the mailing list[1][2], it's not possible to use a cons > > cell like "\,(downcase \1)" in emms-tag-editor-replace-in-tag. > > > > After looking at how quer-replace-regexp handle this case, I patch > > emms-tag-editor-replace-in-tag. > > > > I also fix a bug when using a catch all regexp like "\(.*\)", the > > generator will first try to match on the current line, to replace > > multiple occurrences in the same string. > > > > But '(re-search-forward "\\(.*\\)" (line-end-position) t)' will match > > the end-of-line, making the replacement looping on the same line. > > > > Footnotes: > > [1] http://lists.gnu.org/archive/html/emms-help/2005-07/msg00010.html > > > > [2] https://lists.gnu.org/archive/html/emms-help/2012-01/msg00002.html > > > > ---------------------------------------------------------------- > > Daniel Dehennin (1): > > Make cons cell usable when replacing a tag and fix an end-of-line > match loop. > > > > lisp/emms-tag-editor.el | 23 ++++++++++++++++++----- > > 1 files changed, 18 insertions(+), 5 deletions(-) > > Any news on the review of this patch? > > Regards. > > -- > Daniel Dehennin > Récupérer ma clef GPG: > gpg --keyserver pgp.mit.edu --recv-keys 0x7A6FE2DF > > _______________________________________________ > Emms-help mailing list > Emms-help@gnu.org > https://lists.gnu.org/mailman/listinfo/emms-help > > -- Michael Olson | http://mwolson.org/
_______________________________________________ Emms-help mailing list Emms-help@gnu.org https://lists.gnu.org/mailman/listinfo/emms-help
