Alejandro Erickson <[email protected]> writes: > Thanks for your reply. > > I resolved the error trying to patch against the savannah repo (I had > tried that earlier). The problem was between the chair and the > keyboard. > > The emms devel page (the first thing a new user sees when trying to > learn how to contribute) refers to emms-patches throughout, as well > as emacs wiki as the definitive version of the page. Here https:// > www.gnu.org/software/emms/devel.html
I've updated the wiki to only mention emms-help. > As I understand it, I need to send my patch files to > [email protected] by using `git send-email` and including descriptive > commit messages. Correct? > > Note that the devel page above also refers to a ChangeLog, which is > camel-cased to suggest it's a proper name, but yet it is not a > feature of git that I know of, not a file in emms repo, and the gnu > manual entry for the similarly-named Change Log is... well never > mind, I don't know what a ChangeLog is and I can't figure it out, > that's all :) I did a major rehaul of those texts. > Cheers, > Alejandro > > > On Sun, Jun 19, 2016 at 9:53 PM, Yoni Rabkin <[email protected]> > wrote: > > Alejandro Erickson <[email protected]> writes: > > > Hi, > > I wrote some extra functions for EMMS as I prepared an EMMS > plugin > > for Spacemacs, and I realised I should probably offer the > changes to > > EMMS first. I don't understand how to do that though (this > being my > > first emacs-related contribution). I've read https:// > > www.emacswiki.org/emacs/EMMSDevelopment > > > > I cloned https://github.com/emacsmirror/emms at https:// > github.com/ > > alejandroerickson/emms and made my changes, with one or so > commits > > per feature. Your doc doesn't mention github pull requests > (naïve > > question perhaps, but why?), and when I tried the format-patch > > command I got an the following error: > > > > % git format-patch -M emacsmirror > > > > > > ~/emms (master) > > alejandro > > fatal: ambiguous argument 'emacsmirror': unknown revision or > path not > > in the working tree. > > Use '--' to separate paths from revisions, like this: > > Emms is hosted on Savannah, please send patches to this mailing > list > against the main Savannah git repo: > https://savannah.gnu.org/git/?group=emms > > > The changes include: > > - seek one minute functions (many people have long, 1hr+ > tracks) > > Functions like this are so trivial that they are typically added > by > people in their ~/.emmsrc, but if you'd like to define some new > bindings > along the lines of `emms-seek-forward' I certainly don't mind > adding > them. > > > - remove defunct streams (about half of them don't work, > including DI > > radio that requires premium account to stream outside their > app) > > That would be a very useful patch. Thank you. > > > - a delete function that explicitly moves to trash, rather than > > depending on whether emacs is configured to delete by trashing > or not > > I assume you mean a modification to the Browser, since the > playlist-mode > doesn't offer file-level deletion at all (nor should it). If I > want to > modify the underlying files I hit `d' in the playlist-mode buffer > and > use dired. This makes sense to me instead of duplicating > dired-like > functionality in Emms. > > Since I don't use the Emms Browser at all, I'm probably not the > right > person to weigh in on whether this makes sense. Hopefully someone > who > does use the browser will reply with a useful comment. > > > - play/pause dwim, that tries really hard to play music, even > if the > > playlist is empty > > That isn't enough for me to understand exactly what the patch > does, so I > can't comment. > > > There will probably be more changes as I discover and use more > > features of emms, but I'd like to submit a patch in the > interim. > > Please do, and thank you for working on Emms. > > > Additional question: is there testing code for emms? > > Nope, we keep the main git repo fairly stable and tend to break > stuff in > our own private git branches. That said, there is no problem with > having > people test code in the main branch since there are also stable > release > tarballs to pick from. > > > Note: emms-patches rejected my email. > > We've depreciated emms-patches, is it still listed somewhere? It > shouldn't be. > > > Alejandro > > > > -- > > Dr. Alejandro Erickson > > Postdoctoral Research Associate in Computer Science, Durham > > University, UK > > http://alejandroerickson.com > > > > > > > > _______________________________________________ > > Emms-help mailing list > > [email protected] > > https://lists.gnu.org/mailman/listinfo/emms-help > > > > -- > "Cut your own wood and it will warm you twice" > > > > > -- > Dr. Alejandro Erickson > Postdoctoral Research Associate in Computer Science, Durham > University, UK > http://alejandroerickson.com > > > -- "Cut your own wood and it will warm you twice" _______________________________________________ Emms-help mailing list [email protected] https://lists.gnu.org/mailman/listinfo/emms-help
