In a different direction, I have started testing the tags that emms-info-native produces against what I already have in my cache (which was made by emms-info-taglib, I think). Three things spring out immediately:
1. emms-info-taglib trims trailing white space in strings but emms-info-native does not. 2. emms-info-native puts dates in the year or original-year field while emms-info-taglib puts them in the date or orginaldate field. By date, I mean strings like "2003-11" which contain a month or day separated by hyphens. There are various places in the emms codebase which treat these fields differently (mainly to extract a year "2003" from a date "2003-10"). I suspect that emms-info-native is doing the right thing here (the file is tagged with id3v2.4) but it does have implications for the rest of the codebase. 3. emms-info-native--decode-info-fields is now returning nil for the 75 files for which it raised "id3v2 tag or frame size 3832965 is invalid" errors last week. For definiteness, this is emms-info-native from the info-native branch at commit 0fe6100 ---Fran On Fri, 19 Feb 2021 at 18:15, Petteri Hintsanen <[email protected]> wrote: > "Fran Burstall (Gmail)" <[email protected]> writes: > > > I tried last night's test on the new info-native branch version and got > > zero errors in 14051 files in 371 secs. This is twice as fast as last > > night but nowhere near the 250 tracks a second that Yoni is seeing! > > If you have lots of Ogg or FLAC files in your collection, then that > would explain the difference. Ogg and FLAC parsing is now much slower > than MP3s. > > But it is good to know that there were no errors. Getting rid of errors > was the main reason for doing a new version, performance gains are just > a nice bonus. > > Thank you for your testing. > Regards, > Petteri >
